bpo-35960: Fix dataclasses.field throwing away empty metadata. #11815
Merged
Conversation
remilapeyre
reviewed
Feb 11, 2019
remilapeyre
approved these changes
Feb 11, 2019
ericvsmith
reviewed
Feb 11, 2019
chrahunt
force-pushed
the
fix/bpo-35960
branch
from
February 12, 2019 01:08
bec2bad to
e302e24
Compare
Contributor
|
Thanks @chrahunt for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 12, 2019
…nGH-11815) (cherry picked from commit b01786c) Co-authored-by: Christopher Hunt <chrahunt@gmail.com>
|
GH-11826 is a backport of this pull request to the 3.7 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue35960